Funcsigs fix #2571
Closed
Funcsigs fix #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package-Manager: portage-2.3.0
This commit disables 2 tests because they fail to run with pypy3. This has been reported upstream. Upstream bug: testing-cabal/funcsigs#10 Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=564852 Package-Manager: portage-2.3.0
|
@jlec since you are the assignee of the bug, can you review? |
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
SoapGentoo
suggested changes
Oct 17, 2016
| - pass | ||
| + if platform.python_implementation() != "PyPy": | ||
| + exec(""" | ||
| +def test_signature_on_callable_objects(self): |
There was a problem hiding this comment.
what's with all this whitespace churn? Can you get rid of pure formatting stuff?
There was a problem hiding this comment.
I was just following the style and manner of the rest of the code on how upstream disables certain tests based on certain features.
gentoo-bot
pushed a commit
that referenced
this pull request
Oct 18, 2016
This commit disables 2 tests because they fail to run with pypy3. This has been reported upstream. Upstream bug: testing-cabal/funcsigs#10 Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=564852 Package-Manager: portage-2.3.0 Closes: #2571 Signed-off-by: David Seifert <[email protected]>
paraenggu
pushed a commit
to paraenggu/gentoo
that referenced
this pull request
Oct 23, 2016
Package-Manager: portage-2.3.0 Closes: gentoo#2571 Signed-off-by: David Seifert <[email protected]>
paraenggu
pushed a commit
to paraenggu/gentoo
that referenced
this pull request
Oct 23, 2016
This commit disables 2 tests because they fail to run with pypy3. This has been reported upstream. Upstream bug: testing-cabal/funcsigs#10 Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=564852 Package-Manager: portage-2.3.0 Closes: gentoo#2571 Signed-off-by: David Seifert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-python/funcsigs: fix test issue with pypy3
This commit disables 2 tests because they fail to run with pypy3.
This has been reported upstream.
Upstream bug: testing-cabal/funcsigs#10
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=564852