Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

388 review settings for resfinder #394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Emkago
Copy link
Contributor

@Emkago Emkago commented Feb 3, 2025

Description

Added additional parameters to Resfinder for analysis of Nanopore data

Summary of the changes made:

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Tested with testdata from Illumina and Nanopore that correct parameters are used with respective type of data.

Sign-offs

@Emkago Emkago requested a review from a team as a code owner February 3, 2025 14:20
@Emkago Emkago linked an issue Feb 3, 2025 that may be closed by this pull request
@Emkago
Copy link
Contributor Author

Emkago commented Feb 3, 2025

I have tested the changes with Illumina and Nanopore data, although changes from awaiting PR (fix-hopper-config) have to be implemented for the Nanopore track to run without problems (deactivating fastqc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review settings for Resfinder
1 participant