Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error, hover can't works. #80

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

chunqian
Copy link

No description provided.

@genericptr
Copy link
Owner

@mvancanneyt Was this a copy paste error from your last PR? I need to add you as a reviewer I think, what that be ok?

@mvancanneyt
Copy link
Collaborator

Please add me as a reviewer. Better yet, allow me to collaborate on this repo, so I don't need to do pull requests.

As for the actual patch:

  • The part with ApplySettings is correct.
    An oversight on my part, which I didn't notice during testing.

  • The part with AVL_Tree is not correct:
    The laz_avl_tree unit no longer exists in the latest Lazarus sources.
    The avl_tree unit in FPC is completely equivalent (both were made by Mattias Gaertner).

@chunqian
Copy link
Author

Lazarus main branch use AVL_Tree, Lazarus fixes_3_0 branch use Laz_AVL_Tree.

I primarily use Lazarus as a large-scale FCL, with projects soft linking to the Lazarus's components packager and lcl folder in the .pkg folder. Then, I modify TInitialize.FindPascalSourceDirectories to create an index.

image

Will there be any issues using the code from the main branch?

@mvancanneyt
Copy link
Collaborator

Normally there are no issues. I use main branch Lazarus every day for my work and I don't experience any issues.
I will see if I can add some IFDEF LCLVerision or so for the used unit and the property...

@chunqian
Copy link
Author

Thank you for your response. Now I can confidence use the main branch. However, I'm not sure how to change this RP.

@mvancanneyt
Copy link
Collaborator

Leave it open, we'll close it as soon as I have applied the 'ApplySettings' and possibly the IFDEF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants