fix: catch 4xx errors when fetching balance and continue if it appears (

#176)
geertmeersman · Jan 9, 2025 · ffb8f63 · ffb8f63
2 parents e1bcd8a + dffebaf
commit ffb8f63
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-v1.0.5
+v1.0.6-beta.9
diff --git a/custom_components/mobile_vikings/client.py b/custom_components/mobile_vikings/client.py
@@ -234,16 +234,22 @@ async def get_subscriptions(self):
                     f"/subscriptions/{subscription_id}/modem/settings"
                 )
             else:
-               # Check if the 'sim' field exists and 'msisdn' is not empty
-               sim_info = subscription.get("sim", {})
-               if sim_info.get("msisdn"):
-                   balance = await self.handle_request(
-                       f"/subscriptions/{subscription_id}/balance"
-                   )
-                   subscription["balance"] = balance
-                   subscription["balance_aggregated"] = self.aggregate_bundles_by_type(
-                       balance
-                   )
+                # Check if the 'sim' field exists and 'msisdn' is not empty
+                sim_info = subscription.get("sim", {})
+                if sim_info.get("msisdn"):
+                    try:
+                        balance = await self.handle_request(
+                            f"/subscriptions/{subscription_id}/balance"
+                        )
+                        subscription["balance"] = balance
+                        subscription["balance_aggregated"] = self.aggregate_bundles_by_type(
+                            balance
+                        )
+                    except Exception as e:
+                        _LOGGER.debug(
+                            f"Failed to retrieve balance for subscription {subscription_id}: {e}"
+                        )
+                        # Continue without setting the balance if there's an error
             subscription["product"] = await self.get_product_details(
                 subscription.get("product_id")
             )

diff --git a/custom_components/mobile_vikings/manifest.json b/custom_components/mobile_vikings/manifest.json
@@ -9,5 +9,5 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/geertmeersman/mobile_vikings/issues",
   "requirements": [],
-  "version": "v1.0.5"
+  "version": "v1.0.6-beta.9"
 }