fix: drop the use of pkg_resources #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12rambau
commented
Dec 9, 2024
|
Thank you for the PR. I did that for the leafmap, but forgot to do it for geemap. I used |
giswqs
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2186
As mentioned in the issue,
pkg_resourcesis not part of the default Python distribution anymore so this code is failing completely at import level starting from python 3.11.My idea in this PR is to rely on the
Pathlib for path management and use the internal__file__magic member to find back the path to the geemap folder. I didn't understand how the test were working in isolation so I'm relying on the CI to verify I didn't break anything.