correct exit code assertion in exec plugin #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor for assertions in the exec plugin was incorrectly setting the expected exit code equal to the exit code it received from the test spec, resulting in script or command executions returning non-0 exit codes from causing a test.FailNow(). Signed-off-by: Jay Pipes <[email protected]>
Bring in latest step security and checkout action. Signed-off-by: Jay Pipes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for assertions in the exec plugin was incorrectly setting the expected exit code equal to the exit code it received from the test spec, resulting in script or command executions returning non-0 exit codes from causing a test.FailNow().