Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_gdsfactory9 #432

Merged
merged 3 commits into from
Feb 20, 2025
Merged

update_gdsfactory9 #432

merged 3 commits into from
Feb 20, 2025

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 19, 2025

Summary by Sourcery

Updates the PDK to be compatible with newer versions of gdsfactory and gplugins, and removes unused test files.

Enhancements:

  • Updates gdsfactory to version 9.0.0 and gplugins to version 1.2.4.
  • Removes the explicit width parameter from straight components in netlist YAML files, relying on the cross-section to define the width.
  • Updates the bend component in the ebeam_dc_te1550 component to use bend_s instead of bend_euler.

Chores:

  • Removes unused test files for ring single and double heater components.
  • Updates test YAML files to use strip_length instead of xs_c8b8e980_length and route_info_type: strip instead of route_info_type: xs_c8b8e980.

Copy link
Contributor

sourcery-ai bot commented Feb 19, 2025

Reviewer's Guide by Sourcery

This pull request updates the gdsfactory and gplugins dependencies, updates the route_info_type in the YAML test files for netlists, and removes the width parameter from the straight component in the YAML test files for netlists. It also updates the names of the pad array, pad, taper, straight, and ebeam dc te1550 components in the YAML test files.

Updated class diagram for pad_array

classDiagram
    class pad_array{
        -pad: ComponentSpec
        -column_pitch: float
        -row_pitch: float
    }
    note for pad_array "pad_array now uses column_pitch and row_pitch instead of spacing"
Loading

File-Level Changes

Change Details Files
Updates the route_info_type from a specific cross-section ID to strip and replaces route_info_xs_c8b8e980_length with route_info_strip_length in the YAML test files for netlists.
  • Replaced route_info_type: xs_c8b8e980 with route_info_type: strip.
  • Replaced route_info_xs_c8b8e980_length with route_info_strip_length.
tests/test_netlists/test_netlists_spiral_.yml
tests/test_netlists/test_netlists_ring_single_heater_.yml
tests/test_netlists/test_netlists_ring_double_heater_.yml
tests/test_netlists/test_netlists_ring_single_.yml
tests/test_netlists/test_netlists_coupler90_.yml
tests/test_netlists/test_netlists_coupler_straight_.yml
tests/test_netlists/test_netlists_ring_double_.yml
tests/test_components/test_pdk_settings_straight_.yml
tests/test_components/test_pdk_settings_bend_.yml
tests/test_components/test_pdk_settings_bend_euler180_.yml
tests/test_components/test_pdk_settings_bend_euler_.yml
Updates the gdsfactory dependency and gplugins dependency.
  • Updated gdsfactory dependency to ~=9.0.0.
  • Updated gplugins dependency to gplugins[sax,tidy3d]~=1.2.4.
pyproject.toml
Removes the width parameter from the straight component in the YAML test files for netlists.
  • Added width: null to the straight component.
tests/test_netlists/test_netlists_spiral_.yml
tests/test_netlists/test_netlists_ring_single_.yml
Updates the name of the pad array component in the YAML test file.
  • Renamed pad_array_PFpad_Mgdsfac_1ba46877 to pad_array_PFpad_Mgdsfac_f7490298.
tests/test_components/test_pdk_settings_pad_array_.yml
Updates the name of the pad component in the YAML test file.
  • Renamed pad_S75_75_LM2_ROUTER_B_109b8fd8 to pad_S75_75_LM2_ROUTER_B_a6f49d52.
tests/test_netlists/test_netlists_pad_.yml
Updates the name of the taper component in the YAML test file.
  • Renamed taper_L10_W0p5_WNone_PN_19aa93b7 to taper_L10_W0p5_WNone_LN_08b35698.
tests/test_netlists/test_netlists_taper_.yml
Updates the name of the straight component in the YAML test file.
  • Renamed straight_L10_N2_CSstrip to straight_L10_N2_CSstrip_WNone.
tests/test_netlists/test_netlists_straight_.yml
Updates the name of the ebeam dc te1550 component in the YAML test file.
  • Renamed coupler_G0p236_L20_D4_D_83b94450 to coupler_G0p236_L20_D4_D_b138340a.
tests/test_netlists/test_netlists_ebeam_dc_te1550_.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added the dependencies Pull requests that update a dependency file label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (5727179) to head (5ff1ef0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   70.53%   70.75%   +0.21%     
==========================================
  Files          19       19              
  Lines         723      725       +2     
==========================================
+ Hits          510      513       +3     
+ Misses        213      212       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthewMckee4
Copy link
Member

@joamatab, docs failing is maybe to do with gdsfactory/gplugins#539

@MatthewMckee4 MatthewMckee4 self-requested a review February 20, 2025 21:43
@joamatab
Copy link
Contributor Author

I think the docs were already broken :)

@joamatab joamatab merged commit 2a3ff56 into main Feb 20, 2025
9 of 10 checks passed
@joamatab joamatab deleted the update_gdsfactory9 branch February 20, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants