-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update_gdsfactory9 #432
update_gdsfactory9 #432
Conversation
Reviewer's Guide by SourceryThis pull request updates the gdsfactory and gplugins dependencies, updates the Updated class diagram for pad_arrayclassDiagram
class pad_array{
-pad: ComponentSpec
-column_pitch: float
-row_pitch: float
}
note for pad_array "pad_array now uses column_pitch and row_pitch instead of spacing"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 70.53% 70.75% +0.21%
==========================================
Files 19 19
Lines 723 725 +2
==========================================
+ Hits 510 513 +3
+ Misses 213 212 -1 ☔ View full report in Codecov by Sentry. |
@joamatab, docs failing is maybe to do with gdsfactory/gplugins#539 |
I think the docs were already broken :) |
Summary by Sourcery
Updates the PDK to be compatible with newer versions of gdsfactory and gplugins, and removes unused test files.
Enhancements:
Chores:
strip_length
instead ofxs_c8b8e980_length
androute_info_type: strip
instead ofroute_info_type: xs_c8b8e980
.