Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO02 - Create a route to the BackOffice, allowed to Organizers only #234

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

valekuro
Copy link
Contributor

@valekuro valekuro commented Jul 1, 2024

  • Add 404 page
  • Add backoffice page (visible only if organizer is true)

Copy link

github-actions bot commented Jul 8, 2024

Mobile score

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

Lighthouse ran against http://localhost:4321/

Desktop score

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

Lighthouse ran against http://localhost:4321/

Copy link

github-actions bot commented Jul 15, 2024

Playwright test results

passed  3 passed

Details

stats  3 tests across 1 suite
duration  6.6 seconds
commit  be407a4

src/pages/backoffice.astro Outdated Show resolved Hide resolved
@valekuro valekuro requested a review from irsooti July 31, 2024 08:56
@valekuro
Copy link
Contributor Author

valekuro commented Aug 6, 2024

LGTM
@camillobucciarelli @gregoriopalama is it possible to write some e2e tests using a service account or whatever?

We do have an account we can use for tests. It can't be a service account, but we can provision username and pwd for the organizer account using two secrets. We will need to update the playwright workflow, tho, and it would be preferable to do it in a different PR. This PR LGTM, we will open a new issue for the e2e tests.

@valekuro
Copy link
Contributor Author

valekuro commented Aug 6, 2024

@gregoriopalama Merging with main I have a new error: "Bucket name not specified or invalid. Specify a valid bucket name via the storageBucket option when initializing the app, or specify the bucket name explicitly when calling the getBucket() method."

error bucket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants