Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA01 - Create a check for a11y #101

Merged
merged 18 commits into from
Jan 30, 2024
Merged

INFRA01 - Create a check for a11y #101

merged 18 commits into from
Jan 30, 2024

Conversation

gregoriopalama
Copy link
Member

closes #94

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🔴 Accessibility 0
🟢 Best practices 92
🟠 SEO 55
🔴 PWA 0

Lighthouse ran against http://localhost:4321/

@gregoriopalama
Copy link
Member Author

This will also
close #95

@gregoriopalama gregoriopalama linked an issue Jan 30, 2024 that may be closed by this pull request
INFRA02 - Create a check for performance auditing #95
Closed
@irsooti
Copy link
Collaborator

irsooti commented Jan 30, 2024

LGTM!

Just curious: you are using pnpm caching in a different and longer way than I did in #96, do you see any issues about that?

See the lines: https://github.com/gdgpescara/hedwig/pull/99/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3R12-R19 .

@gregoriopalama
Copy link
Member Author

Nope, I'm using the default retention, should be fine.
Also, a lot of nice things are still not supported in pnpm and there are open PRs right now.

We should monitor this: pnpm/action-setup#99
And update our workflows as soon as this get merged

@irsooti
Copy link
Collaborator

irsooti commented Jan 30, 2024

oof

@irsooti irsooti merged commit a93dd5a into main Jan 30, 2024
2 checks passed
@gregoriopalama gregoriopalama mentioned this pull request Jan 30, 2024
Merged
@irsooti irsooti deleted the INFRA01 branch January 31, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irsooti irsooti irsooti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INFRA02 - Create a check for performance auditing INFRA01 - Create a check for a11y
2 participants
@gregoriopalama @irsooti