Optimise writeString for Windows with vtEnabled #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bios-Marcel
force-pushed
the
optimise_windows_vt_write_string
branch
3 times, most recently
from
793b306 to
ddc2e12
Compare
Instead of doing 3 `WriteConsole` calls, we do a single call that sets the cursor, sets the style and writes the content. This gives us a performance boost of up to 3x faster.
Bios-Marcel
force-pushed
the
optimise_windows_vt_write_string
branch
from
ddc2e12 to
dca8a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing 3
WriteConsolecalls, we do a single call that sets thecursor, sets the style and writes the content. This gives us a
performance boost of up to 3x faster.