Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bai 1544 show entry kind for all results in top right search #1778

Merged

Conversation

IR96334
Copy link
Member

@IR96334 IR96334 commented Jan 22, 2025

Adds chip denoting entry kind to top-right search results to help user differentiate

textOverflow: 'ellipsis',
overflow: 'hidden',
color: theme.palette.primary.main,
maxWidth: '400px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is set to the same width as the surrounding box, really long names will appear under the entry kind chip. I'd suggest instead of settings this to a specific amount of pixels, giving it a marginRight. If you change style to sx on line 70 you can use mr: 6, which should give enough padding.

/>
</ListItemButton>
secondary: {
style: { whiteSpace: 'nowrap', textOverflow: 'ellipsis', overflow: 'hidden', maxWidth: '400px' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use sx here instead of style.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, see my other comment about changing the maxWidth property to be margin instead

secondary={entry.description}
slotProps={{
primary: {
style: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use sx here instead of style.

@IR96334 IR96334 requested a review from ARADDCC002 January 24, 2025 12:46
@IR96334 IR96334 merged commit afd3fc8 into main Jan 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants