-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bai 1544 show entry kind for all results in top right search #1778
Bai 1544 show entry kind for all results in top right search #1778
Conversation
…earch' of https://github.com/gchq/Bailo into BAI-1544-show-entry-kind-for-all-results-in-top-right-search
frontend/src/wrapper/EntrySearch.tsx
Outdated
textOverflow: 'ellipsis', | ||
overflow: 'hidden', | ||
color: theme.palette.primary.main, | ||
maxWidth: '400px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is set to the same width as the surrounding box, really long names will appear under the entry kind chip. I'd suggest instead of settings this to a specific amount of pixels, giving it a marginRight
. If you change style
to sx
on line 70 you can use mr: 6
, which should give enough padding.
frontend/src/wrapper/EntrySearch.tsx
Outdated
/> | ||
</ListItemButton> | ||
secondary: { | ||
style: { whiteSpace: 'nowrap', textOverflow: 'ellipsis', overflow: 'hidden', maxWidth: '400px' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use sx
here instead of style
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, see my other comment about changing the maxWidth
property to be margin instead
frontend/src/wrapper/EntrySearch.tsx
Outdated
secondary={entry.description} | ||
slotProps={{ | ||
primary: { | ||
style: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use sx
here instead of style
.
Adds chip denoting entry kind to top-right search results to help user differentiate