Bump @typescript-eslint/eslint-plugin from 7.16.0 to 8.19.0 in /backend

backend/package.json

@@ -94,8 +94,8 @@
     "@types/shelljs": "^0.8.15",
     "@types/supertest": "^6.0.2",
     "@types/uuid": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^7.16.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.19.0",
+    "@typescript-eslint/parser": "^8.19.0",
     "@vitest/coverage-v8": "^2.1.4",
     "eslint": "^8.57.0",
     "eslint-plugin-prettier": "^5.2.1",

backend/src/clients/cognito.ts

@@ -5,6 +5,7 @@ import {
 } from '@aws-sdk/client-cognito-identity-provider'
 
 import { UserInformation } from '../connectors/authentication/Base.js'
+import log from '../services/log.js'
 import config from '../utils/config.js'
 import { ConfigurationError, InternalError } from '../utils/error.js'
 
@@ -14,7 +15,8 @@ export async function listUsers(query: string, exactMatch = false) {
   try {
     dnName = config.oauth.cognito.userIdAttribute
     userPoolId = config.oauth.cognito.userPoolId
-  } catch (e) {
+  } catch (err) {
+    log.error(err)
     throw ConfigurationError('Cannot find userIdAttribute in oauth configuration', { oauthConfiguration: config.oauth })
   }
 

backend/src/connectors/fileScanning/clamAv.ts

@@ -28,6 +28,7 @@ export class ClamAvFileScanningConnector extends BaseFileScanningConnector {
           av = await new NodeClam().init({ clamdscan: config.avScanning.clamdscan })
           log.info('Clam AV initialised.')
         } catch (error) {
+          log.error(error)
           log.warn(`Could not initialise Clam AV, retrying (attempt ${retryCount})...`)
           this.init(++retryCount)
         }

backend/src/connectors/fileScanning/index.ts

@@ -1,3 +1,4 @@
+import log from '../../services/log.js'
 import config from '../../utils/config.js'
 import { ConfigurationError } from '../../utils/error.js'
 import { BaseFileScanningConnector } from './Base.js'
@@ -25,6 +26,7 @@ export function runFileScanners(cache = true) {
           await scanner.init()
           fileScanConnectors.push(scanner)
         } catch (error) {
+          log.error(error)
           throw ConfigurationError('Could not configure or initialise Clam AV')
         }
         break
@@ -34,6 +36,7 @@ export function runFileScanners(cache = true) {
           await scanner.init()
           fileScanConnectors.push(scanner)
         } catch (error) {
+          log.error(error)
           throw ConfigurationError('Could not configure or initialise ModelScan')
         }
         break

backend/src/connectors/fileScanning/modelScan.ts

@@ -27,6 +27,7 @@ export class ModelScanFileScanningConnector extends BaseFileScanningConnector {
           await getModelScanInfo()
           log.info('ModelScan initialised.')
         } catch (error) {
+          log.error(error)
           log.warn(`Could not initialise ModelScan, retrying (attempt ${retryCount})...`)
           this.init(++retryCount)
         }

backend/src/migrations/011_find_and_remove_invalid_users.ts

@@ -1,6 +1,7 @@
 import authentication from '../connectors/authentication/index.js'
 import { MigrationMetadata } from '../models/Migration.js'
 import ModelModel from '../models/Model.js'
+import log from '../services/log.js'
 
 /**
  * As we now do backend validation for users being added to model access lists, we
@@ -21,6 +22,7 @@ export async function up() {
           try {
             await authentication.getUserInformation(collaborator.entity)
           } catch (err) {
+            log.error(err)
             invalidUsers.push(collaborator.entity)
           }
         }

backend/src/services/migration.ts

@@ -13,12 +13,14 @@ export async function doesMigrationExist(name: string) {
 }
 
 export async function markMigrationComplete(name: string, metadata: MigrationMetadata | undefined) {
-  metadata
-    ? await MigrationModel.create({
-        name,
-        metadata,
-      })
-    : await MigrationModel.create({
-        name,
-      })
+  if (metadata) {
+    await MigrationModel.create({
+      name,
+      metadata,
+    })
+  } else {
+    await MigrationModel.create({
+      name,
+    })
+  }
 }

backend/test/clients/cognito.spec.ts

@@ -17,6 +17,12 @@ const configMock = vi.hoisted(
           },
         },
       },
+      log: {
+        level: 'info',
+      },
+      instrumentation: {
+        enabled: false,
+      },
     }) as any,
 )
 vi.mock('../../src/utils/config.js', () => ({

backend/test/models/Token.spec.ts

@@ -27,7 +27,7 @@ describe('models > Token', () => {
     const token = new TokenModel()
     const result = await token.compareToken('abc')
 
-    expect(result).false
+    expect(result).toBe(false)
   })
 
   test('compareToken > return bcrypt error thrown when comparing', async () => {
@@ -59,7 +59,7 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).true
+    expect(result).toBe(true)
   })
 
   test('compareToken > return false on unsuccessful bcrypt comparison', async () => {
@@ -70,7 +70,7 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).false
+    expect(result).toBe(false)
   })
 
   test('compareToken > return true on successful sha256 comparison', async () => {
@@ -81,7 +81,7 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).true
+    expect(result).toBe(true)
   })
 
   test('compareToken > return true on successful sha256 comparison', async () => {
@@ -92,7 +92,7 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).true
+    expect(result).toBe(true)
   })
 
   test('compareToken > return true on successful sha256 comparison', async () => {
@@ -103,7 +103,7 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).true
+    expect(result).toBe(true)
   })
 
   test('compareToken > return false on unsuccessful sha256 comparison', async () => {
@@ -114,6 +114,6 @@ describe('models > Token', () => {
 
     const result = await token.compareToken('abc')
 
-    expect(result).false
+    expect(result).toBe(false)
   })
 })

backend/test/services/model.spec.ts

@@ -418,7 +418,7 @@
   test('setLatestImportedModelCard > success', async () => {
     await setLatestImportedModelCard('abc')
 
-    expect(modelMocks.updateOne).toHaveBeenCalledOnce
+    expect(modelMocks.updateOne).toHaveBeenCalledOnce()
   })
 
   test('setLatestImportedModelCard > cannot find latest model card', async () => {