Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAI-461 Update next/legacy/image to next/image #1580

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2024

No description provided.

@ghost ghost self-assigned this Oct 22, 2024
@ghost ghost added the dependencies Pull requests that update a dependency file label Oct 22, 2024
@ghost ghost marked this pull request as ready for review October 28, 2024 09:59
Copy link
Contributor

@PE39806 PE39806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in frontend/pages/docs/v1 still use import Image from 'next/legacy/image'. Even though they are "hidden" from the left navigation panel they are still accessible so require either completely removing or updating as with the rest of the files.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ PE39806
❌ KW86022


KW86022 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PE39806
Copy link
Contributor

PE39806 commented Nov 5, 2024

The files in frontend/pages/docs/v1 still use import Image from 'next/legacy/image'. Even though they are "hidden" from the left navigation panel they are still accessible so require either completely removing or updating as with the rest of the files.

I've gone with updating the files as they are still wanted from a legacy perspective.

@PE39806 PE39806 force-pushed the fix/BAI-461-remove-next-legacy-image-behaviour branch from 989b8fe to 35de983 Compare November 6, 2024 11:19
PE39806
PE39806 previously approved these changes Dec 12, 2024
@PE39806 PE39806 dismissed their stale review December 12, 2024 08:12

I've acted on my own review so need someone else to independently review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants