Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace new game div with dialog #1811

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace new game div with dialog #1811

wants to merge 1 commit into from

Conversation

randompearl-stack
Copy link
Contributor

No description provided.

@gbtami
Copy link
Owner

gbtami commented Mar 9, 2025 •
edited
Loading

Almost there :)
After preesing Esc it should remove the orange color from the CREATE GAME/PLAY WITH A FRIEND/etc. buttons.

Btw we should rework this stuff and use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog, but not in this PR of course :)

@randompearl-stack
Copy link
Contributor Author

I mean then what is the point... Modal dialogs by default allow escaping to close. So I'll revert and try to implement dialog.

@randompearl-stack randompearl-stack marked this pull request as draft March 10, 2025 05:42
@randompearl-stack randompearl-stack changed the title Allow escape to close new game modal: #1646 Replace new game div with dialog Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randompearl-stack @gbtami