Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide links on mobile! #1809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CSSandHTMLonly
Copy link
Contributor

No description provided.

@gbtami
Copy link
Owner

gbtami commented Mar 3, 2025

U Can't Touch This CSS file (it is for Bughouse only!)

@CSSandHTMLonly
Copy link
Contributor Author

CSSandHTMLonly commented Mar 4, 2025

U Can't Touch This CSS file (it is for Bughouse only!)

Idk, kinda confused, but those code makin' these link not display: https://imgur.com/AGlCKN5

Perhaps they use the same variable name? :/

anyways, i don't think that would do any harm to bughouse page...

Edit: seems like in bughouse it is used to hide spectators name on mobile, but it has made those link disappear too, perhaps coz they have same name.. "under-left" again I'm not sure...

@randompearl-stack
Copy link
Contributor

Not all of bughouse.css is needed for general site pages. I think it should be split based on the commented divisions (analysis, round, extensions, and site) and added to these larger files.

@gbtami
Copy link
Owner

gbtami commented Mar 6, 2025

bughouse.css contains bughouse related stuff only and keeping them in one file helps to develop two board variants.
If you want to prevent hiding links on mobile you have to do your changes in site.css

@randompearl-stack
Copy link
Contributor

That's true but for pages like /puzzles, /players, /variants there is no point in linking bughouse.css. Also on the home page only a portion of it is needed for the 4 player seeks.

@gbtami
Copy link
Owner

gbtami commented Mar 7, 2025

Ohh, I see now, you are right. I was thinking that everything in bughouse.css has bughouse specific selectors, but seem this is not true in case of "under-left" and we can safely remove it from this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants