Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -L flag in galactic-armada Makefile #116

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

warut-vijit
Copy link
Contributor

@warut-vijit warut-vijit commented Jan 9, 2025

Addresses issue identified in #97 where the removed -L flag is passed to rgbasm in the galactic-armada Makefile, causing make to fail. This flag was removed in #94 in July.

@warut-vijit warut-vijit changed the title Remove deprecated -L flag in galactic-armada Makefile Remove -L flag in galactic-armada Makefile Jan 9, 2025
@warut-vijit
Copy link
Contributor Author

Thank you for the review @avivace
Github says that the PR still requires a maintainer review to merge. Do you happen to know who that might be?

@avivace avivace merged commit 1b9e920 into gbdev:master Jan 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants