Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: require the topology is stable for longer before auto-suspending #420

Merged
merged 1 commit into from
Feb 7, 2025
Merged

broker: require the topology is stable for longer before auto-suspending #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions broker/replica.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,18 @@ func pulseDaemon(svc *Service, r *replica) {
var ctx, cancel = context.WithTimeout(r.ctx, healthCheckInterval)

// If AutoSuspend is enabled, use the SUSPEND_IF_FLUSHED control flag
// after at least one `healthCheckInterval` has elapsed. We cannot use
// SUSPEND_IF_FLUSHED immediately because there's a natural startup race
// with the client(s) which resumed and intend to append to the journal.
// only after a number of stable `healthCheckInterval`s have elapsed.
// We do this for a few reasons:
// * There's a natural startup race with the client(s) which resumed
// and intend to append to the journal.
// * We may be both primary and newly-added to the topology.
// There may be fragments which are or have persisted, which we
// haven't yet observed while awaiting the next fragment refresh.
// * If journal topologies are changing rapidly for some reason,
// we don't want to compound the problem by suspending journals,
// which changes their effective replication factor.
var suspend = pb.AppendRequest_SUSPEND_NO_RESUME
if AutoSuspend && stableTicks >= 1 {
if AutoSuspend && stableTicks >= 15 {
suspend = pb.AppendRequest_SUSPEND_IF_FLUSHED
}

Expand Down