-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo in tutorials/message_generation.md #494
Conversation
tutorials/message_generation.md
Outdated
@@ -85,7 +85,7 @@ For each file: | |||
|
|||
* `gz_msgs_protoc` accepts the arguments necessary to find all the supporting | |||
scripts and executables: | |||
* `gz_msgs_generate.py` - Top-level python script entrypoint for generating messages. | |||
* `gz_msgs_generate.py` - Top-level python script entry point for generating messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say entrypoint
is valid. It's an alternative form of entry point
. Do you mind to restore this change ?
tutorials/message_generation.md
Outdated
@@ -85,7 +85,7 @@ For each file: | |||
|
|||
* `gz_msgs_protoc` accepts the arguments necessary to find all the supporting | |||
scripts and executables: | |||
* `gz_msgs_generate.py` - Top-level python script entrypoint for generating messages. | |||
* `gz_msgs_generate.py` - Top-level python script entry point for generating messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `gz_msgs_generate.py` - Top-level python script entry point for generating messages. | |
* `gz_msgs_generate.py` - Top-level python script entrypoint for generating messages. |
Got it. I have updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to sign the commits ?
Corrected "restrctions" to "restrictions" in the documentation. Signed-off-by: anshium <[email protected]>
I am sorry, I followed an incorrect procedure while signing. My commits had the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also check other md
and md.in
files? I believe there are spell issues in other files as well.
I did iterate through other files and ran aspell for each of them again. Could not find any other typos though. Not sure if I am missing something. Checked for typos in:
|
feel free to open another PR if you find more typos. Thank you for your contribution |
Corrected "restrctions" to "restrictions" and "entrypoint" to "entry point" in the documentation.
🦟 Bug fix
Fixes #493
Summary
Iterated through all the .md and .md.in files. Found 2 typos in the tutorials/message_generation.md file.
Checklist
codecheck
passed (See contributing)