feat: introduce default interactive mode #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
commented
Mar 5, 2024
| @@ -17,16 +17,13 @@ final class GatlingPlugin implements Plugin<Project> { | |||
|
|
|||
| public static def GATLING_RECORDER_TASK_NAME = 'gatlingRecorder' | |||
|
|
|||
| static String GATLING_TASK_NAME_PREFIX = "$GATLING_RUN_TASK_NAME-" | |||
There was a problem hiding this comment.
gatlingRun-FQCN is dropped in favor of gatling --simulation=FQCN
slandelle
force-pushed
the
feat-interactive-mode
branch
4 times, most recently
from
e797bb8 to
b5fae64
Compare
Isammoc
reviewed
Mar 6, 2024
src/main/groovy/io/gatling/gradle/GatlingPluginExtension.groovy
Outdated
Show resolved
Hide resolved
Isammoc
approved these changes
Mar 7, 2024
guilgaly
approved these changes
Mar 11, 2024
slandelle
force-pushed
the
feat-interactive-mode
branch
from
747e8fe to
763da7a
Compare
Motivation: We want to align the maven and the gradle plugins behavior. In particular, we want it to be interactive by default, with a simulation selection prompt.
slandelle
force-pushed
the
feat-interactive-mode
branch
2 times, most recently
from
0fd1731 to
e7db854
Compare
Isammoc
approved these changes
Mar 12, 2024
src/test/resources/gradle-layout-kotlin/src/gatling/resources/search.csv
Outdated
Show resolved
Hide resolved
src/test/resources/gradle-layout-kotlin/src/main/java/computerdatabase/MainUtils.java
Outdated
Show resolved
Hide resolved
src/test/resources/gradle-layout-kotlin/src/test/java/computerdatabase/TestUtils.java
Outdated
Show resolved
Hide resolved
src/test/resources/gradle-layout-scala/src/gatling/resources/search.csv
Outdated
Show resolved
Hide resolved
src/test/resources/gradle-layout-scala/src/main/java/computerdatabase/MainUtils.java
Outdated
Show resolved
Hide resolved
src/test/resources/gradle-layout-scala/src/test/java/computerdatabase/TestUtils.java
Outdated
Show resolved
Hide resolved
slandelle
force-pushed
the
feat-interactive-mode
branch
from
2fe7fc0 to
a7d4dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to align the maven and the gradle plugins behavior.
In particular, we want it to be interactive by default, with a simulation selection prompt.