Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for running external commands #356

Merged
merged 8 commits into from
Feb 17, 2025
Merged

feat: add support for running external commands #356

merged 8 commits into from
Feb 17, 2025

Conversation

dnaeon
Copy link
Member

@dnaeon dnaeon commented Feb 11, 2025

What this PR does / why we need it:

This PR introduces a new task for running external commands - common:task:payload.

Also:

  • Added short option names for the various queue, page and size options of inventory task sub-commands
  • Re-organized the package of common tasks into separate files

Release note:

Added new task for running external commands - `common:task:command`

@dnaeon dnaeon requested a review from a team as a code owner February 11, 2025 15:46
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 11, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 11, 2025
Bobi-Wan
Bobi-Wan reviewed Feb 16, 2025
View reviewed changes
cmd/inventory/tasks.go Outdated Show resolved Hide resolved
pkg/common/tasks/queue_mgmt.go Outdated Show resolved Hide resolved
pkg/common/tasks/queue_mgmt.go Outdated Show resolved Hide resolved
@dnaeon dnaeon force-pushed the feat/external-command-task branch from 6d34a89 to affca95 Compare February 17, 2025 08:20
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
Bobi-Wan
Bobi-Wan approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Bobi-Wan Bobi-Wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 17, 2025
@dnaeon dnaeon merged commit de7dfb4 into gardener:main Feb 17, 2025
6 checks passed
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobi-Wan Bobi-Wan Bobi-Wan approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnaeon @Bobi-Wan @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot