Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UseEtcdWrapper feature gate #999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove UseEtcdWrapper feature gate #999

wants to merge 1 commit into from

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area usability
/kind cleanup

What this PR does / why we need it:
Remove UseEtcdWrapper feature gate, since it has now moved out of GA and is unconditionally part of the code base.

Which issue(s) this PR fixes:
Fixes #935

Release note:

Remove `UseEtcdWrapper` feature gate since it is now out of GA and always enabled.

@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner February 13, 2025 05:21
@gardener-robot gardener-robot added area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 13, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 13, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 13, 2025
@shreyas-s-rao
Copy link
Contributor Author

/test pull-etcd-druid-api-unit

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 13, 2025

@shreyas-s-rao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-api-unit e21a82a link false /test pull-etcd-druid-api-unit

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyas-s-rao
Copy link
Contributor Author

/hold until #988 is merged, to avoid rebasing and also to ensure that pull-etcd-druid-api-unit can pass then.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 13, 2025
@shreyas-s-rao shreyas-s-rao added this to the v0.28.0 milestone Feb 13, 2025
ishan16696
ishan16696 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

Remove GA feature gate UseEtcdWrapper
6 participants
@shreyas-s-rao @ishan16696 @anveshreddy18 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot