[Security Hardened Shoot Cluster] Rule 1002 implementation #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
dimityrmirchev
requested changes
Feb 10, 2025
| } else if kind == gardencorev1beta1constants.CloudProfileReferenceKindNamespacedCloudProfile { | ||
| namespacedCloudProfile = &gardencorev1beta1.NamespacedCloudProfile{ObjectMeta: v1.ObjectMeta{Name: cloudProfileName, Namespace: r.ShootNamespace}} | ||
| if err := r.Client.Get(ctx, client.ObjectKeyFromObject(namespacedCloudProfile), namespacedCloudProfile); err != nil { | ||
| return rule.Result(r, rule.ErroredCheckResult(err.Error(), rule.NewTarget("name", cloudProfileName, "namespace", r.ShootNamespace, "kind", "NamespacedCloudProfile"))), nil |
There was a problem hiding this comment.
Suggested change
| return rule.Result(r, rule.ErroredCheckResult(err.Error(), rule.NewTarget("name", cloudProfileName, "namespace", r.ShootNamespace, "kind", "NamespacedCloudProfile"))), nil | |
| return rule.Result(r, rule.ErroredCheckResult(err.Error(), rule.NewTarget("name", cloudProfileName, "namespace", r.ShootNamespace, "kind", gardencorev1beta1constants.CloudProfileReferenceKindNamespacedCloudProfile))), nil |
| } | ||
| } | ||
|
|
||
| return []string{string(core.ClassificationSupported)} |
There was a problem hiding this comment.
Can we directly use the Classification type?
Comment on lines
172
to
178
| if version.Classification == nil { | ||
| return rule.FailedCheckResult("Worker group uses image with unclassified image.", target), true | ||
| } else if slices.Contains(r.acceptedClassifications(imageName), string(*version.Classification)) { | ||
| return rule.PassedCheckResult("Worker group has accepted image.", target.With("classification", string(*version.Classification))), true | ||
| } else { | ||
| return rule.FailedCheckResult("Worker group has not accepted image.", target.With("classification", string(*version.Classification))), true | ||
| } |
| return rule.ErroredCheckResult("image version not found in namespacedCloudProfile", target) | ||
| } | ||
|
|
||
| func (r *Rule1002) checkCloudProfile( |
There was a problem hiding this comment.
Probably not needed if only used in one place
| return rule.Result(r, checkResults...), nil | ||
| } | ||
|
|
||
| func (r *Rule1002) checkImageVersion( |
There was a problem hiding this comment.
This function can be removed?
example/config/garden.yaml
Outdated
| # - name: image-name | ||
| # expectedClassifications: | ||
| # - supported | ||
| # - supported |
There was a problem hiding this comment.
Duplicate rows. Probably a typo
gardener-robot
added
size/xl
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #430
Special notes for your reviewer:
Release note: