-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wildcard option for volumes contained in AcceptedPods for Rules 2003 and 2008 #409
Add a wildcard option for volumes contained in AcceptedPods for Rules 2003 and 2008 #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the proper example in the sample configuration file
I will push the guide change to #406 to avoid merge conflicts later on. |
I am not sure what you mean. I mean having the new wildcard value shown here On a similar note I think that we should also do the same changes for rule 2008. WDYT? |
I assumed that you meant the guide configuration that will be used by the stakeholders. I agree that 2008 could benefit from the same mechanism, so I will add the changes to that rule too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
What this PR does / why we need it:
This PR contains a modification to the acceptedResources handling in Rules 2003 and 2008 of the Security Hardened Kubernetes Ruleset by adding the option to accept all volumes in an accepted pod by using a wildcard.
Which issue(s) this PR fixes:
Fixes #407
Special notes for your reviewer:
Release note: