fix(cluster-buildkit): assume image needs rebuild if skopeo command fails and print a warning #6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
approved these changes
Jan 28, 2025
vvagaytsev
requested changes
Jan 28, 2025
vvagaytsev
reviewed
Jan 28, 2025
vvagaytsev
previously approved these changes
Jan 29, 2025
stefreak
commented
Jan 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ails and print a warning Instead of failing completely, assume image needs to be rebuilt and print a warning. This is meant as a pain releave for the issue encountered in this Discord thread: https://discord.com/channels/817392104711651328/1313997959121211463/1313997959121211463 This is not a full solution for the problem encountered in the thread.
chore: fix build
stefreak
force-pushed
the
fix-skopeo-autherror
branch
from
326660a to
f68a33b
Compare
vvagaytsev
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of failing completely, assume image needs to be rebuilt and print a warning.
This is meant as a pain relieve for the issue encountered in this Discord thread: https://discord.com/channels/817392104711651328/1313997959121211463/1313997959121211463
This is not a full solution for the problem encountered in the thread.
Special notes for your reviewer: