Option to allow localhost and allowlist #27
+350
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `disable_net_connect!` will block any outgoing requests. However, some development environments include core infrastructure which requires gRPC communication. For example, projects utilizing a Bigtable emulator that need to keep this dependency functioning as part of the local system while simultanesouly needing disable system-external gRPC calls. This commit provides an option to allow localhost-like connections, and specify an allowlist of hosts for which gRPC requests should not be disabled. It shadows the pattern used by the Webmock Ruby library.
niborg
commented
Oct 4, 2024
| def initialize | ||
| @client = Hello::Hello::Stub.new('localhost:8000', :this_channel_is_insecure) | ||
| def initialize(host = 'localhost:8000') | ||
| @client = Hello::Hello::Stub.new(host, :this_channel_is_insecure) |
There was a problem hiding this comment.
Change makes it easier for specs to make request to external endpoints so we can test that gRPC requests are bypassing GrpcMock.
niborg
commented
Oct 4, 2024
| end | ||
|
|
||
| def send_message(msg, client_stream: false, server_stream: false, metadata: {}) | ||
| def send_message(msg, client_stream: false, server_stream: false, metadata: {}, timeout: 0.1) |
There was a problem hiding this comment.
Spec requests to localhost fail immediately, but when the tests try to hit a fake outside service we need a timeout to keep things fast.
|
@ganmacs any thoughts on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
disable_net_connect!will block any outgoing requests. However, some development environments include core infrastructure which requires gRPC communication. For example, projects utilizing a Bigtable emulator that need to keep this dependency functioning as part of the local system while simultanesouly needing disable system-external gRPC calls.This commit provides an option to allow localhost-like connections, and specify an allowlist of hosts for which gRPC requests should not be disabled. It shadows the pattern used by the Webmock Ruby library.