Require semantic version for model parameter version string #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w |
| """ | ||
| if version is None: | ||
| return | ||
| semver_regex = r"^\d+\.\d+\.\d+(-[0-9A-Za-z.-]+)?(\+[0-9A-Za-z.-]+)?$" |
There was a problem hiding this comment.
Not perfectly familiar with regex. Does this here allow also number.number.number-(additional expression)?
There was a problem hiding this comment.
Yes - but see also #1115
| "1.0.0", | ||
| "0.1.0", | ||
| "2.3.4", | ||
| "1.0.0-alpha", |
There was a problem hiding this comment.
Related to above question. So we really want to allow this kind of version structure?
There was a problem hiding this comment.
This is how semantic versioning is defined, see https://semver.org/
tobiaskleiner
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model versions have changed to semantic versioning with this model_parameters PR.
Add here:
validate_camera_efficiency_sststest for prod6 only (as Derived-DB is not updated with the new versioning; see issue Review and replace derived value DB #1070)