-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integer attribute of particle #348
Conversation
@hyschive Thanks for the review. I have addressed the comment. Please take another review. |
@ChunYen-Chen I encountered the following error messages when using
I suspect the issue arises because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChunYen-Chen I've added some final minor comments, including a few bug fixes. Please also resolve the conflicts.
src/TestProblem/Hydro/ClusterMerger/Par_Init_ByFunction_ClusterMerger.cpp
Show resolved
Hide resolved
Co-authored-by: Hsi-Yu Schive <[email protected]>
Co-authored-by: Hsi-Yu Schive <[email protected]>
Conflicts: doc/wiki/Runtime-Parameters-related/Runtime-Parameters:-Particles.md include/TestProb.h src/Output/Output_DumpData_Total_HDF5.cpp src/TestProblem/Template/Init_TestProb_Template.cpp
This PR allows the user to use integer attributes of particles and solves part of #79.
Changes
PAR_TYPE
is now a built-in integer attribute.PAR_IC
is updated.PAR_NATT_USER
toPAR_NATT_FLT_USER
.New
create_PAR_IC.cpp
to generate newPAR_IC
files.INT8_PAR
(--long_par
inconfigure.py
) to control the precision of the integer attributes.PAR_NATT_INT_USER
(--par_attribute_int
inconfigure.py
).Note
yt
module does not recognize the integer attribute type correctly.gamer_compare_data
is not supported yet.libyt
is also not supported yet.