Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Executors #72

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Fix macOS Executors #72

merged 8 commits into from
Jun 12, 2024

Conversation

GabLeRoux
Copy link
Member

@GabLeRoux GabLeRoux commented Jun 12, 2024

Closes #71

@GabLeRoux GabLeRoux changed the title bump versions 2024 06 12 Bump versions Jun 12, 2024
@GabLeRoux
Copy link
Member Author

Job was rejected because resource class large, image xcode:15.3.0 is not a valid resource class

🤔

@thedrhax14
Copy link
Contributor

On top of that it is unable to activate unity license (here at line 33)

@GabLeRoux
Copy link
Member Author

GabLeRoux commented Jun 12, 2024

Indeed, license activation that is failing is likely due to changes from Unity. I wrote a fix for gitlab-ci a while back (which omg I should definitely merge, I'll find some time this summer to clean things up).

We're basically activating by extracting a serial out of a free license file.

@GabLeRoux
Copy link
Member Author

I'm not actively using this orb, but if anyone would like to help me bring this back up and running, don't hesitate to ping me and I'll create a release once we get the activation working again 🙏

@GabLeRoux
Copy link
Member Author

GabLeRoux commented Jun 12, 2024

I managed to get the macOs jobs to run again by using macos.m1.medium.gen1, but now they're failing with activation. I would say it is now better than it used to be. All we need is to fix the activation steps which we can inspire by what was done in here.

More precisely in before_script.sh

@GabLeRoux GabLeRoux changed the title Bump versions Fix macOS Executors Jun 12, 2024
@thedrhax14
Copy link
Contributor

thedrhax14 commented Jun 12, 2024

I managed to get the macOs jobs to run again by using macos.m1.medium.gen1, but now they're failing with activation. I would say it is now better than it used to be. All we need is to fix the activation steps which we can inspire by what was done in here

(1) Does it mean an actual license (at least personal license) should be used? (2) As far as I understood anyone who has the environment variables for unity license set in their circleci account then the pipeline should work, right? (3) Or is it still necessarily to update the sh scripts as well?

@GabLeRoux
Copy link
Member Author

(1) Does it mean an actual license (at least personal license) should be used?

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side, we set these env vars for the github actions to properly test the actions:

  • UNITY_EMAIL
  • UNITY_LICENSE
  • UNITY_PASSWORD
  • UNITY_SERIAL

(2) As far as I understood anyone who has the environment variables for unity license set in their circleci account then the pipeline should work, right?

I'm not a 100% sure. This would be preferable indeed, but we're facing the activation issues with the version 3.x.x of the Docker images which might be a breaking change for activation so I wouldn't count too much on it.

To do this the right way, we should keep fixing things and then decide if we release 1.8.0 or 2.0.0 for this orb. The only way we can confirm this would be to have an already working project with orb running on 1.7.0 and then try the pipelines again with updated codebase (once we fix the activation scripts in current repo).

(3) Or is it still necessarily to update the sh scripts as well?

I think so.

@GabLeRoux
Copy link
Member Author

GabLeRoux commented Jun 12, 2024

I'll merge this in main branch as well (main branch is already unstable and wasn't up to date with latest Unity versions anyway).

At least we're using updated macOS Executors in here now 🚀

Let's figure out the best way to solve activation for this orb and bring it back to life :)

@GabLeRoux GabLeRoux merged commit b9538e1 into main Jun 12, 2024
1 of 2 checks passed
@GabLeRoux GabLeRoux deleted the bump-versions-2024-06-12 branch June 12, 2024 19:41
@thedrhax14
Copy link
Contributor

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side,

My only suspicion after inspecting last pipeline is that current UNITY_LICENSE or UNITY_SERIAL is either revoked or expired. I hope I was looking at a right part of it

@GabLeRoux
Copy link
Member Author

GabLeRoux commented Jun 12, 2024

I think there's already one configured for the current repository in CircleCI's side. Or it used to. On Github side,

My only suspicion after inspecting last pipeline is that current UNITY_LICENSE or UNITY_SERIAL is either revoked or expired. I hope I was looking at a right part of it

That sounds right, I'll see if I have access to the settings and fill some of them again.
edit1: I currently don't have access to the secrets. I'll try to reach original authors or CircleCI and see what we can do 🙏
edit2: I had to re-authorize my github link in CircleCI and I now have access to the org, I'll be able to update the secrets if needed.

@GabLeRoux
Copy link
Member Author

I've created two followup issues:

I'll ping some people around to see if they can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job was rejected because resource class large, image xcode:13.4.1 is not a valid resource class
2 participants