Support prebuilt client #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
requested review from
hexylena and
natefoo
and removed request for
hexylena
dometto
force-pushed
the
prebuilt_client
branch
from
3273905 to
bb4892e
Compare
|
Pinging @natefoo again |
|
Hello! Would be great to get a review of this. |
|
Sorry for the wait, I will review this ASAP. |
|
Sorry for spamming with pings @natefoo but it would be great to know if this will be integrated in the main role ❤️! |
|
I've rebased this on |
|
Note that the tests for rocky are failing because I rebased this PR on top of ffb86cd, and that commit seems to break them. |
hexylena
approved these changes
Jul 22, 2024
|
Is anybody running this? It sounds like a very good thing. :) |
|
I guess this is severely limited by the availability of the client matching the releases at https://www.npmjs.com/package/@galaxyproject/galaxy-client?activeTab=versions ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #207
This PR:
client.yml.pre_tasksfrom the default scenario into a separate file.