fix: handle SyncingStatus from erigon

[tsbernar]

Motivation

The syncing() eth_syncing rpc call fails on Erigon clients when the node is not synced. Erigon gives a different response format that we fail to parse. This change adds handling for the Erigon response format: https://github.com/ledgerwatch/erigon/blob/6a1bb1dff1deca7a50d66bfbc9e0b89bb4e335a1/turbo/jsonrpc/eth_system.go#L70-L74

Solution

Modifies the SyncProgress struct to handle all responses, adds a unit test.

PR Checklist

• Added Tests
• Added Documentation - just code comments
• Breaking changes

[mattsse]

sorry for the late review

this does not match the "spec", or rather breaks it with the optional starting_block field, which is not great

[tsbernar]

sorry for the late review

this does not match the "spec", or rather breaks it with the optional starting_block field, which is not great

Thanks for the review @mattsse.
What do you think the right approach for this would be if not making it optional? Maybe some other pattern of having opt-in client specific types? I was just trying to be compatible with erigon from here:

https://github.com/ledgerwatch/erigon/blob/6a1bb1dff1deca7a50d66bfbc9e0b89bb4e335a1/turbo/jsonrpc/eth_system.go

Erigon is quite popular so I don't think we should be unable to parse responses from this client.

[mattsse]

I think it's fine

only thing we need is pub fields

[tsbernar]

I think it's fine

only thing we need is pub fields

Hey @mattsse, I've made that update now