Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update permissions; remove credentials #1359

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Feb 24, 2025

This PR:

  • Removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue
  • Declares the minimum permissions for the workflows to run at the workflow level in feature.yaml and at the job level in main.yaml, following principle of least privilege; see related GitHub security post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant