Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): fix repository url; add homepage and bugs urls #1339

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 18, 2024

The repository URL was fixed by simply running npm pkg fix, which is what npm publish does prior to publishing.

The addition of the homepage property allows for the URL to the repo to be correctly displayed when hovered over in VS Code when using a proxy registry like in Azure DevOps:

image

Compared to eslint-plugin-regexp, which does have the homepage set:

image

The bugs property was also added to allow for npm bugs to work.

@Fdawgs Fdawgs changed the title chore(package): fix repository url chore(package): fix repository url; add homepage url Nov 18, 2024
@Fdawgs Fdawgs changed the title chore(package): fix repository url; add homepage url chore(package): fix repository url; add homepage and bugs urls Nov 18, 2024
@brettz9 brettz9 merged commit d3c24f5 into gajus:main Nov 19, 2024
5 checks passed
@brettz9
Copy link
Collaborator

brettz9 commented Nov 19, 2024

Thanks for the PR!

@Fdawgs Fdawgs deleted the patch-1 branch November 19, 2024 06:26
Copy link

🎉 This issue has been resolved in version 50.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants