Faster get function for views
#90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
force-pushed
the
faster-get-3
branch
3 times, most recently
from
01dda85 to
e1d74e8
Compare
CodSpeed Performance ReportMerging #90 will not alter performanceComparing Summary
|
thegedge
approved these changes
May 31, 2024
Comment on lines
+41
to
+51
| let value = this[$memos].${property}; | ||
| if (value != $notYetMemoized) { | ||
| return value; | ||
| } | ||
|
|
||
| value = getValue.call(this); | ||
| this[$memos].${property} = value; | ||
| return value; |
There was a problem hiding this comment.
Curious if you tried overriding the descriptor with the memoized value, and if so, was that an improvement?
Object.defineProperty(this, "${property}", { value, writable: false })
return value;Would eliminate the need for this[$memos]
airhorns
force-pushed
the
faster-get-3
branch
3 times, most recently
from
f94b020 to
b928fdb
Compare
…ched views This implements a better performing getter function for readonly instances. Before this, we used the same definition of the getter function for all views, which ended up megamorphic, because it accessed a very wide variety of properties for every instance! Instead, this evals a monomorphic getter for each one. I also changed the object that stores the memos to have a fixed shape from birth by evaling it out as well. I also changed us to use one object to store all the memoized values, instead of two. We were previously using two in order to implement memoization of undefined and null correctly, but with the new strategy to initialize an object with slots for every memo from the start, we can populate it with a `$notYetMemoized` symbol that indicates if we have memoized or not.
|
Closing in favor of #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a better performing getter function for readonly instances. Before this, we used the same definition of the getter function for all views, which ended up megamorphic, because it accessed a very wide variety of properties for every instance! Instead, this evals a monomorphic getter for each one. I also changed the object that stores the memos to have a fixed shape from birth by evaling it out as well.
I also changed us to use one object to store all the memoized values, instead of two. We were previously using two in order to implement memoization of undefined and null correctly, but with the new strategy to initialize an object with slots for every memo from the start, we can populate it with a
$notYetMemoizedsymbol that indicates if we have memoized or not.