Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only test =)) #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ You're now on the new branch `my_pretty_branch_for_pr_1` and ready to work!

Find the file you want to modify and modify it. Change the code, etc... I won't detail here how to run the test suite as it's optional in open source projects. Especially if the modification is small. A server will run some tests for you anyway. So let's go on.

[longnn] I modified this readme for testing purpose.

### Step 5: Push your branch

This is quite simple:
Expand Down Expand Up @@ -125,6 +127,8 @@ There are nowadays many CI providers: Travis CI, CircleCI, Azure pilelines, Gith

### Step 8 (optional): Add more commits to your pull request

[longnn] Some more edit

The pull request is now done, but there is still the code review. You might need to wait for a few days until a maintainer reviews your code.

Once the maintainer does, if everything is good, you'll get some thanks and your pull request will be merged.
Expand Down
1 change: 1 addition & 0 deletions longnn.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello world!