Issue 93 binder #99
Merged
Issue 93 binder #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialization, and updated notebooks to be used on binder.
… to use vnorm rest dp
…to use for the notebooks
wesleygoar
requested review from
andreasprlic,
ahwagner and
larrybabb
as code owners
larrybabb
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
This looks great to me @wesleygoar . I'm not sure I am confident enough to approve this as I haven't been in the mix in dealing with the issue you are resolving.
That said, I don't see how holding this up is helpful or how it may hurt if we merge it sooner than later. So I'm approving it.
ahwagner
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
Updated Data Proxy Paths so the notebooks require no local installation of seqrepo or uta. Also updated the binder environment files to automatically run make devready and setup the required venv for running the notebooks.