This repository has been archived by the owner on May 4, 2019. It is now read-only.
Protobuf 3.2.0 #82
Open
Protobuf 3.2.0 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david4096
suggested changes
Apr 3, 2017
|
Ooh, yeah, I didn't intend to add any tests here, hope I didn't accidentally include something from a different branch. Which test is the issue? I had to add some stuff to |
david4096
suggested changes
Apr 4, 2017
| @@ -0,0 +1,6 @@ | |||
| package fakeobj; | |||
| extension_scope=None | ||
| ) | ||
| ], nested_types=[], enum_types=[], extensions=[]) | ||
|
|
||
| def makeFakeObject(self): |
There was a problem hiding this comment.
Ah, yeah - that's the same as https://github.com/ljdursi/ga4gh-client/blob/master/tests/unit/test_cli.py#L430 , but with the stricter C++ implementation it actually needs to be a .proto file that gets compiled into a _pb2.py .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps protobuf version to 3.2.0, which means C++ implementation on Linux and so faster/reduced memory usage. Addresses issue ga4gh/ga4gh-server#1623.
The C++ implementation is fussier than the python version - this means had to explicitly create a "proper" FakeObject for tests/unit/test_cli.py. It also means that pythonic things like conversion between string types doesn't happen automatically, so that strings passed to protobuf routines have to be byte strings, not unicode strings