Skip to content

Commit

Permalink
Do not include default javacopts
Browse files Browse the repository at this point in the history
rules_java already includes the toolchain's default javacopts when
compiling java_library.

Please see:
https://github.com/bazelbuild/rules_java/blob/f26a240c3392f0ae45a2ce3244c93713d7539611/java/common/rules/java_toolchain.bzl#L167

fixes bazelbuild#1685
  • Loading branch information
fzakaria committed Jan 24, 2025
1 parent a8ae50e commit b3cf2c0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions scala/private/rule_impls.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ def compile_java(ctx, source_jars, source_files, output, extra_javac_opts, provi
output = output,
javac_opts = expand_location(
ctx,
java_common.default_javac_opts(
java_toolchain = java_toolchain,
) + extra_javac_opts,
extra_javac_opts
),
deps = providers_of_dependencies,
#exports can be empty since the manually created provider exposes exports
Expand Down

0 comments on commit b3cf2c0

Please sign in to comment.