We can ignore warnings if the request for background execution is not waiting #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
requested changes
Feb 6, 2025
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Feb 6, 2025
Once fyne-io#5509 is merged, running binding callbacks from main no longer print a warning so we cna avoid checking the thread. The result is much faster performance. I also fixed a bug where we ere scheduling s.DataChanged() onto main, which then runs a trigger() which schedules other work onto main. That was unnecessary overhead.
3 tasks
Jacalz
approved these changes
Feb 6, 2025
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Feb 7, 2025
Once fyne-io#5509 is merged, running binding callbacks from main no longer print a warning so we cna avoid checking the thread. The result is much faster performance. I also fixed a bug where we ere scheduling s.DataChanged() onto main, which then runs a trigger() which schedules other work onto main. That was unnecessary overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed on #5508 , main (not waiting) from main is OK now.
Checklist: