Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make table scrolling and resizing more efficient #5496

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Make table scrolling and resizing more efficient #5496

merged 3 commits into from
Feb 5, 2025

Conversation

dweymouth
Copy link
Contributor

Description:

Only refresh newly visible cells when scrolling and resizing the table

Progresses #5456 (for Table)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 3, 2025 •
edited
Loading

Coverage Status

coverage: 62.563% (-0.06%) from 62.619%
when pulling ef1a3f1 on dweymouth:efficient-table-size-scroll
into 5ebf631 on fyne-io:develop.

andydotxyz
andydotxyz previously requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, nice solution.
Just a drive-by comment as I've not managed to test the code yet - but let's unexport methods by default

Jacalz
Jacalz requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. +1 on Andy's review and just a tip about early return

@dweymouth dweymouth dismissed andydotxyz’s stale review February 5, 2025 12:17

change addressed

@dweymouth dweymouth merged commit 9ddfa4c into fyne-io:develop Feb 5, 2025
11 checks passed
@dweymouth dweymouth deleted the efficient-table-size-scroll branch February 5, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

@andydotxyz andydotxyz Awaiting requested review from andydotxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz