Fyne_Demo now running free from race reports #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not using the final API but I wanted to progress tasks as while working on trickier details. I will move this to public API when it is decided, a simple refactor will cover it. In the meantime I can no longer get any reports from in fyne_demo
dweymouth
approved these changes
Jan 8, 2025
Jacalz
reviewed
Jan 8, 2025
|
Oh. It looks like this was merged while I was reviewing :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not using the final API but I wanted to progress tasks as while working on trickier details. I will move this to public API when it is decided, a simple refactor will cover it.
In the meantime I can no longer get any reports from in fyne_demo
Fixes #4568
Relates to #4654
Checklist:
-race- tests are a separate PR