Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.6.1 #289

Merged
merged 29 commits into from
Jan 21, 2025
Merged

Release 2.6.1 #289

merged 29 commits into from
Jan 21, 2025

Conversation

lucor
Copy link
Member

@lucor lucor commented Jan 12, 2025

Description:

This PR contains the 2.6.1 release

Checklist:

  • Tests included.
  • Lint and formatter run with no errors. (*)
  • Tests all pass.

(*) Note: lint fails due to #288 but it should not be a release blocker issue

nobe4 and others added 28 commits May 6, 2024 09:24
@nobe4
fix: update install suggestion for missing fyne command
fda64ff 
This makes the install process more inline with the CI workflow, where
both are tested
@nobe4
fix: remove go get when installing this command
26515d9 
cc fyne-io#248 (review)
@andydotxyz
Merge pull request fyne-io#248 from nobe4/fix-missing-requirement
187fb53 
fix: update install suggestion for missing `fyne` command
@williambrode
fix: Large performance boost by avoiding running simple preparation i…
c870d6b 
…n docker
@Bluebugs
Merge pull request fyne-io#254 from williambrode/cleanDirPerformance
c007692 
Performance improvement by avoiding running commands in docker
Merge branch 'master' into develop
85cf21e
@Bluebugs
Merge pull request fyne-io#265 from fyne-io/sync-master2develop
228a7da 
Sync master2develop
@andydotxyz
Fixing so we don't seek a missing android image for darwin
18ed90a
@andydotxyz
Updating to versions of Fyne
5acc31a
@andydotxyz
Don't use a version that requires a newer Go compiler
437c03c
@andydotxyz
oops, typo in version
9428532
@andydotxyz
Fix deprecations from Go 1.19
1df19d4
@Bluebugs
Merge pull request fyne-io#268 from andydotxyz/fix/267
3716efe 
Fixing so we don't seek a missing android image for darwin
@andydotxyz
Merge branch 'master' into develop
8cdaf07
@metal3d @andydotxyz
Fix Android release that generates a .aab file
d632e96 
Creating Android release generates a .aab file. The Build() function was
working with *.apk files only. So the AAB file was not copied and
triggered a SELinux error. The copy sh command failed also.

This commit fixes the problem by changing the pattern to match on copy,
and the package name using ".aab" suffix.

NOTE: it could be better to use filepath.Glob() to find files and use
os.Rename() instead.
@andydotxyz
Use a staticcheck that understands some of the test deps
ee14a68
@lucor
Merge branch 'master' into develop
a17f304
@lucor
Update the compress deps as far as we can with Go 1.19
54a977e
@lucor
Merge pull request fyne-io#283 from lucor/develop
7e8957f 
Merge master into develop
@lucor
web: update destination folder
5975fb6 
This commit updates the destination folder to wasm.
Fixes:
- fyne-io/fyne-cross-images#50
- fyne-io/fyne-cross-images#55
@lucor
metadata: update Fyne metadata to v2.5.3
94f3322
@lucor
doc: apply linter suggestions
b2efed9
@lucor
readme: update macos SDK extract section
3de5b14 
Fixes fyne-io#282
@lucor
readme: update Go requirements
2003794
@lucor
Merge pull request fyne-io#287 from lucor/doc/readme-macos-extract-sdk
7df055a 
readme: update the requirements and the macos SDK extract section
@lucor
Merge pull request fyne-io#286 from lucor/metadata-sync
3f364f7 
metadata: update Fyne metadata to v2.5.3
@lucor
Merge pull request fyne-io#285 from lucor/fix/web-rename-destination-…
e9f4650 
…folder

web: update destination folder
@lucor
readme: update changelog for release 2.6.1
3381206
@andydotxyz
Copy link
Member

(*) Note: lint fails due to #288 but it should not be a release blocker issue

Agreed, but the two web build failures are probably to be resolved:

/usr/bin/docker run --rm -t -w /app -v /home/runner/work/fyne-cross/fyne-cross/calculator:/app:z --platform linux/amd64 --user 1001 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build docker.io/fyneio/fyne-cross-images:web /usr/local/bin/fyne package -os web -name calculator -icon /app/fyne-cross/tmp/web/Icon.png -appBuild 11 -appVersion 1.1.0 -appID io.fyne.calculator -release
/usr/bin/docker run --rm -t -w /app -v /home/runner/work/fyne-cross/fyne-cross/calculator:/app:z --platform linux/amd64 --user 1001 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build docker.io/fyneio/fyne-cross-images:web mv /app/wasm /app/fyne-cross/tmp/web
mv: cannot stat '/app/wasm': No such file or directory
[✗] exit status 1

@lucor lucor mentioned this pull request Jan 13, 2025
Merged
@lucor
Copy link
Member Author

lucor commented Jan 13, 2025

(*) Note: lint fails due to #288 but it should not be a release blocker issue

Agreed, but the two web build failures are probably to be resolved:

/usr/bin/docker run --rm -t -w /app -v /home/runner/work/fyne-cross/fyne-cross/calculator:/app:z --platform linux/amd64 --user 1001 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build docker.io/fyneio/fyne-cross-images:web /usr/local/bin/fyne package -os web -name calculator -icon /app/fyne-cross/tmp/web/Icon.png -appBuild 11 -appVersion 1.1.0 -appID io.fyne.calculator -release
/usr/bin/docker run --rm -t -w /app -v /home/runner/work/fyne-cross/fyne-cross/calculator:/app:z --platform linux/amd64 --user 1001 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build docker.io/fyneio/fyne-cross-images:web mv /app/wasm /app/fyne-cross/tmp/web
mv: cannot stat '/app/wasm': No such file or directory
[✗] exit status 1

Agreed, this is the chicken-egg dilemma. CI uses old fyne-cross-images that has an old fyne CLI inside :)
All should work once fyne-cross 2.6.1 and fyne-cross-images in fyne-io/fyne-cross-images#55 are released

Jacalz
Jacalz requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Lets just get the static analysis and web CI runs passing and this should be good to go :)

@andydotxyz
Copy link
Member

Thanks to @Bluebugs for resolving the CI issues I think this should pass if it merges in the changes landed...

@lucor
Copy link
Member Author

lucor commented Jan 21, 2025

Thanks to latest @Bluebugs fixes and fyne-cross-image release the CI in now happy :) and everything should be ready for the new release.

Bluebugs
Bluebugs approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Bluebugs Bluebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@Jacalz
Copy link
Member

Jacalz commented Jan 21, 2025

Many thanks for working on this :)

@lucor lucor merged commit 706b4fc into fyne-io:master Jan 21, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

@Bluebugs Bluebugs Bluebugs approved these changes

@andydotxyz andydotxyz Awaiting requested review from andydotxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucor @andydotxyz @Jacalz @Bluebugs @nobe4 @williambrode @metal3d