Skip to content

Commit

Permalink
Add more trackers to mileage flow
Browse files Browse the repository at this point in the history
  • Loading branch information
arjunaj5 committed Jan 17, 2025
1 parent 64e8104 commit d6c5c4a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/app/core/services/tracking.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,14 @@ export class TrackingService {
this.eventTrack('Edit Expense Error', properties);
}

editMileageError(properties: { label: Error }): void {
this.eventTrack('Edit Mileage Error', properties);
}

editPerDiemError(properties: { label: Error }): void {
this.eventTrack('Edit Per Diem Error', properties);
}

// adding expenses in existing report event
addToExistingReport(properties = {}): void {
this.eventTrack('Add Expenses to Report', properties);
Expand Down
4 changes: 4 additions & 0 deletions src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2651,6 +2651,10 @@ export class AddEditMileagePage implements OnInit {

// NOTE: This double call is done as certain fields will not be present in return of upsert call. policy_amount in this case.
return this.transactionService.upsert(etxn.tx as Transaction).pipe(
catchError((error: Error) => {
this.trackingService.editMileageError({ label: error });
return throwError(() => error);
}),
switchMap((txn) => this.expensesService.getExpenseById(txn.id)),
map((expense) => this.transactionService.transformExpense(expense).tx),
switchMap((tx) => {
Expand Down
4 changes: 4 additions & 0 deletions src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2146,6 +2146,10 @@ export class AddEditPerDiemPage implements OnInit {
}

return this.transactionService.upsert(etxn.tx).pipe(
catchError((error: Error) => {
this.trackingService.editPerDiemError({ label: error });
return throwError(() => error);
}),
switchMap((txn) => this.expensesService.getExpenseById(txn.id)),
map((expense) => this.transactionService.transformExpense(expense).tx),
switchMap((tx) => {
Expand Down

0 comments on commit d6c5c4a

Please sign in to comment.