Adapting bookmarks to allow rendering blobs #2
Conversation
albertopq
force-pushed
the
bookmarks-sites
branch
3 times, most recently
from
4d9894a to
b2ab864
Compare
| @@ -389,7 +389,8 @@ window.GaiaAppIcon = (function(exports) { | |||
| }; | |||
|
|
|||
| proto._relayout = function() { | |||
| this._size = this.clientWidth; | |||
| var bookmarkIcon = this.bookmark && this.bookmark.icon; | |||
| this._size = this.clientWidth || (bookmarkIcon && bookmarkIcon.size); | |||
There was a problem hiding this comment.
I'm not certain this change makes sense - the component is designed to be added to the DOM before it gets refreshed so it can know its size (alternatively, a size can be set on it via style, I suppose?) - this just means we may end up with badly scaled icons when it does get added to the DOM (even if bookmarkIcon.size ends up larger than clientWidth, down-scaling can also look bad and wastes memory).
There was a problem hiding this comment.
The problem is that we are not appending the element to the DOM in the case of the chrome. We just replace the backgroundImage with the one created by the component. I tried to set the size via style without adding it to the DOM and didn't seem to work for me...
There was a problem hiding this comment.
ah, I see - why don't we use the component instead of taking its background image? The problem is this will break that optimisation for bookmarks when the component is being used normally.
No description provided.