Skip to content

Commit

Permalink
code cleanup (see cms-sw#22)
Browse files Browse the repository at this point in the history
  - move all ConfDB v2 code in a single package
  • Loading branch information
fwyzard committed Jan 13, 2016
1 parent 15654ff commit 9bb4019
Show file tree
Hide file tree
Showing 13 changed files with 16 additions and 20 deletions.
1 change: 0 additions & 1 deletion Server/Application_py266/confdb_tables/__init__.py

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# File confdb_queries.py Description:
# File confdb_v2/queries.py Description:
# This files contains the implementations of the methods providing the query
# to retrieve records from the ConfDb
#
Expand All @@ -12,8 +12,8 @@
from operator import attrgetter
from sqlalchemy import Table, Column, Integer, String, MetaData, ForeignKey

from confdb_tables.confdb_tables import *
#from sqlalchemy_plugin.saplugin import Version, Pathidconf, Pathids, Paths, Pathitems, Pathelement, Modelement, Moduleitem, ModTelement, ModToTemp, ModTemplate, Directory, Configuration, Moduletypes,
from .tables import *


class ConfDbQueries(object):

Expand Down
5 changes: 1 addition & 4 deletions Server/Application_py266/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
engine.start()
session = None

from utils import *
#cnfMap = UniqueMapping()

import logging
# create console handler and set level to debug
console = logging.StreamHandler()
Expand All @@ -51,7 +48,7 @@
from converter.converter import Converter
converter = Converter()

from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
queries = ConfDbQueries()
ver = queries.getConfigurationByName(name, session, logger)
cnf = -1
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/converter/converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
# Class: Converter

from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
from item_wrappers.FolderItem import *
from item_wrappers.ModuleDetails import *
from item_wrappers.Pathitem import *
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/converter/data_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import itertools
import re
from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
from item_wrappers.FolderItem import *
from item_wrappers.ModuleDetails import *
from item_wrappers.Pathitem import *
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/converter/task.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from sqlalchemy.ext.automap import automap_base
from sqlalchemy import create_engine
from sqlalchemy.orm import scoped_session, sessionmaker
from confdb_tables.confdb_tables import Base
from confdb_v2.tables import Base
from data_builder import DataBuilder
from utils import Timer
from Config import *
Expand Down
10 changes: 5 additions & 5 deletions Server/Application_py266/exposed/exposed.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# Class: Exposed

from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
from item_wrappers.FolderItem import *
from item_wrappers.ModuleDetails import *
from item_wrappers.Pathitem import *
Expand Down Expand Up @@ -584,7 +584,7 @@ def getChildrenDirectories(self, id_parent, folMap, cnfMap, db, log):
child_directories = queries.getChildDirectories(dir_id, db, log)

#get Child configurations
configs = queries.getConfigsInDir(dir_id, db)
configs = queries.getConfigsInDir(dir_id, db, log)

except Exception as e:
msg = 'ERROR: Query getChildDirectories/getConfigsInDir Error: ' + e.args[0]
Expand All @@ -608,7 +608,7 @@ def getChildrenDirectories(self, id_parent, folMap, cnfMap, db, log):
dir_childs = queries.getChildDirectories(d.id, db, log)

#get Child configurations
cnf_childs = queries.getConfigsInDir(d.id, db)
cnf_childs = queries.getConfigsInDir(d.id, db, log)

except Exception as e:
msg = 'ERROR: Query getChildDirectories/getConfigsInDir Error: ' + e.args[0]
Expand Down Expand Up @@ -689,7 +689,7 @@ def getRootDirectory(self, folMap, cnfMap, folMap_online, db, log):
child_directories = queries.getChildDirectories(fRoot.id, db, log)

#get Child configurations
configs = queries.getConfigsInDir(fRoot.id, db)
configs = queries.getConfigsInDir(fRoot.id, db, log)

except Exception as e:
msg = 'ERROR: Query getChildDirectories/getConfigsInDir Error: ' + e.args[0]
Expand All @@ -712,7 +712,7 @@ def getRootDirectory(self, folMap, cnfMap, folMap_online, db, log):
dir_childs = queries.getChildDirectories(d.id, db, log)

#get Child configurations
cnf_childs = queries.getConfigsInDir(d.id, db)
cnf_childs = queries.getConfigsInDir(d.id, db, log)

except Exception as e:
msg = 'ERROR: Query getChildDirectories/getConfigsInDir Error: ' + e.args[0]
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/exposed/parser_functions.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Class: Parser_Functions

from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
from item_wrappers.FolderItem import *
from item_wrappers.ModuleDetails import *
from item_wrappers.Pathitem import *
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/exposed/summary_builder.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from confdb_queries.confdb_queries import ConfDbQueries
from confdb_v2.queries import ConfDbQueries
from item_wrappers.FolderItem import *
from item_wrappers.ModuleDetails import *
from item_wrappers.Pathitem import *
Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/sqlalchemy_plugin/saengine.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from sqlalchemy.ext.automap import automap_base
from sqlalchemy import Sequence
from sqlalchemy import Table, Column, Integer, String, MetaData, ForeignKey
from confdb_tables.confdb_tables import *
from confdb_v2.tables import *

__all__ = ['SAEngine']

Expand Down
2 changes: 1 addition & 1 deletion Server/Application_py266/sqlalchemy_plugin/saplugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from sqlalchemy.ext.automap import automap_base
from sqlalchemy import Sequence
from sqlalchemy import Table, Column, Integer, String, MetaData, ForeignKey
from confdb_tables.confdb_tables import *
from confdb_v2.tables import *

__all__ = ['SAEnginePlugin']

Expand Down

0 comments on commit 9bb4019

Please sign in to comment.