refactor(test): move feature tests under /test

futurice · Feb 26, 2024 · eabec60 · eabec60
1 parent 8352918
commit eabec60
Show file tree

Hide file tree

Showing 21 changed files with 15 additions and 3 deletions.
diff --git a/internal/cli/check_test.go → test/check_test.go b/internal/cli/check_test.go → test/check_test.go
diff --git a/internal/cli/create_test.go → test/create_test.go b/internal/cli/create_test.go → test/create_test.go
diff --git a/internal/cli/eject_test.go → test/eject_test.go b/internal/cli/eject_test.go → test/eject_test.go
diff --git a/internal/cli/execute_test.go → test/execute_test.go b/internal/cli/execute_test.go → test/execute_test.go
diff --git a/test/check-file-origin.feature → test/features/check-file-origin.feature b/test/check-file-origin.feature → test/features/check-file-origin.feature
diff --git a/test/check-recipes.feature → test/features/check-recipes.feature b/test/check-recipes.feature → test/features/check-recipes.feature
diff --git a/test/create-recipes.feature → test/features/create-recipes.feature b/test/create-recipes.feature → test/features/create-recipes.feature
diff --git a/test/eject.feature → test/features/eject.feature b/test/eject.feature → test/features/eject.feature
diff --git a/test/execute-recipes.feature → test/features/execute-recipes.feature b/test/execute-recipes.feature → test/features/execute-recipes.feature
diff --git a/test/jalapenoignore.feature → test/features/jalapenoignore.feature b/test/jalapenoignore.feature → test/features/jalapenoignore.feature
diff --git a/test/recipe-tests.feature → test/features/recipe-tests.feature b/test/recipe-tests.feature → test/features/recipe-tests.feature
diff --git a/test/recipes-as-oci-artifacts.feature → ...features/recipes-as-oci-artifacts.feature b/test/recipes-as-oci-artifacts.feature → ...features/recipes-as-oci-artifacts.feature
@@ -12,13 +12,14 @@ Feature: Recipes as OCI artifacts
 
 	Scenario: Pull a recipe from OCI repository
 		Given a recipes directory
+		And a project directory
 		And a recipe "foo"
 		And recipe "foo" generates file "README.md" with content "initial"
 		And a local OCI registry
 		And the recipe "foo" is pushed to the local OCI repository "foo:v0.0.1"
 		When I pull the recipe "foo" from the local OCI repository "foo:v0.0.1"
 		Then no errors were printed
-		And the recipes directory should contain recipe "foo"
+		And the project directory should contain file "foo/recipe.yml"
 
 	Scenario: Push a recipe to OCI repository with authentication
 		Given a recipes directory
@@ -30,13 +31,14 @@ Feature: Recipes as OCI artifacts
 
 	Scenario: Pull a recipe from OCI repository with authentication
 		Given a recipes directory
+		And a project directory
 		And a recipe "foo"
 		And recipe "foo" generates file "README.md" with content "initial"
 		And a local OCI registry with authentication
 		And the recipe "foo" is pushed to the local OCI repository "foo:v0.0.1"
 		When I pull the recipe "foo" from the local OCI repository "foo:v0.0.1"
 		Then no errors were printed
-		And the recipes directory should contain recipe "foo"
+		And the project directory should contain file "foo/recipe.yml"
 
 	Scenario: Try to push a recipe to OCI repository without authentication
 		Given a recipes directory
@@ -49,6 +51,7 @@ Feature: Recipes as OCI artifacts
 
 	Scenario: Try to pull a recipe from OCI repository which not exist
 		Given a recipes directory
+		And a project directory
 		And a local OCI registry with authentication
 		When I pull the recipe "foo" from the local OCI repository "foo:v0.0.1"
 		Then CLI produced an error "recipe not found"

diff --git a/test/upgrade-recipe.feature → test/features/upgrade-recipe.feature b/test/upgrade-recipe.feature → test/features/upgrade-recipe.feature
diff --git a/test/validate-recipe.feature → test/features/validate-recipe.feature b/test/validate-recipe.feature → test/features/validate-recipe.feature
diff --git a/internal/cli/cmds_test.go → test/main_test.go b/internal/cli/cmds_test.go → test/main_test.go
@@ -44,6 +44,7 @@ type (
 	cmdStdErrCtxKey                 struct{}
 	cmdAdditionalFlagsCtxKey        struct{}
 	dockerResourcesCtxKey           struct{}
+	scenarioNameCtxKey              struct{}
 )
 
 type OCIRegistry struct {
@@ -117,6 +118,7 @@ func TestFeatures(t *testing.T) {
 				ctx = context.WithValue(ctx, cmdAdditionalFlagsCtxKey{}, make(map[string]string))
 				ctx = context.WithValue(ctx, dockerResourcesCtxKey{}, []*dockertest.Resource{})
 				ctx = context.WithValue(ctx, cmdStdInCtxKey{}, NewBlockBuffer())
+				ctx = context.WithValue(ctx, scenarioNameCtxKey{}, sc.Name)
 
 				return ctx, nil
 			})
@@ -128,7 +130,7 @@ func TestFeatures(t *testing.T) {
 			Strict:      true,
 			Concurrency: 8,
 			Format:      "pretty",
-			Paths:       []string{"../../test"},
+			Paths:       []string{"./features"},
 			TestingT:    t,
 		},
 	}
@@ -289,9 +291,14 @@ func bufferKeysToInput(ctx context.Context, keys string) (context.Context, error
 
 func aRecipe(ctx context.Context, recipeName string) (context.Context, error) {
 	dir := ctx.Value(recipesDirectoryPathCtxKey{}).(string)
+	scenarioName := ctx.Value(scenarioNameCtxKey{}).(string)
+
 	re := recipe.NewRecipe()
 	re.Name = recipeName
 	re.Version = "v0.0.1"
+	re.Description = scenarioName
+
+	fmt.Println(dir)
 
 	if err := re.Save(filepath.Join(dir, recipeName)); err != nil {
 		return ctx, err

diff --git a/internal/cli/pull_test.go → test/pull_test.go b/internal/cli/pull_test.go → test/pull_test.go
@@ -13,12 +13,14 @@ func AddPullSteps(s *godog.ScenarioContext) {
 }
 
 func iPullRecipe(ctx context.Context, recipeName, repoName string) (context.Context, error) {
+	dir := ctx.Value(projectDirectoryPathCtxKey{}).(string)
 	ociRegistry := ctx.Value(ociRegistryCtxKey{}).(OCIRegistry)
 	configDir, configFileExists := ctx.Value(dockerConfigDirectoryPathCtxKey{}).(string)
 
 	args := []string{
 		"pull",
 		filepath.Join(ociRegistry.Resource.GetHostPort("5000/tcp"), repoName),
+		fmt.Sprintf("--dir=%s", dir),
 	}
 
 	if ociRegistry.TLSEnabled {

diff --git a/internal/cli/push_test.go → test/push_test.go b/internal/cli/push_test.go → test/push_test.go
diff --git a/internal/cli/test_test.go → test/test_test.go b/internal/cli/test_test.go → test/test_test.go
diff --git a/internal/cli/upgrade_test.go → test/upgrade_test.go b/internal/cli/upgrade_test.go → test/upgrade_test.go
diff --git a/internal/cli/validate_test.go → test/validate_test.go b/internal/cli/validate_test.go → test/validate_test.go
diff --git a/internal/cli/why_test.go → test/why_test.go b/internal/cli/why_test.go → test/why_test.go