Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitブランチ規約: arch-guidelinesリポジトリへ引っ越し #233

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

ma91n
Copy link
Collaborator

@ma91n ma91n commented Jan 29, 2025

Gitブランチ規約は、コーディング規約とは言い難いため、arch-guidelines リポジトリに移動させる。

マッピング(移行対象ページ ※画像などは除く)

From To
https://future-architect.github.io/coding-standards/documents/forGitBranch/git_branch_standards.html https://future-architect.github.io/arch-guidelines/documents/forGitBranch/git_branch_standards.html
https://future-architect.github.io/coding-standards/documents/forGitBranch/index.html https://future-architect.github.io/arch-guidelines/documents/forGitBranch/index.html

Step

  1. arch-guidelinesリポジトリに、Gitブランチ規約の資材をコピー
  2. coding-standards 側の、Gitブランチのページに対して、リダイレクト用のファイルを設置
    • public/documents/fotGitBranch に対して、index.html, git_branch_standards.html の2つ
  3. coding-standards 側のGitブランチ規約用のジョブ定義や導線などを削除

はてブ対応

https://b.hatena.ne.jp/help/entry/canonicalization にあるように <link rel="canoninal" href="https://example.com/" /> の対応でOK.

これは https://theorangeone.net/posts/redirecting-static-pages/#the-result で指定された方法と同様である。

@ma91n ma91n self-assigned this Jan 29, 2025
Copy link

stackblitz bot commented Jan 29, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今回の作業目的からは範囲外ですが、Markdown定義の引っ越し時の削除漏れでしたので、あわせて削除しました。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移行用ファイル1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移行用ファイル2

@ma91n ma91n requested a review from ota-meshi January 29, 2025 14:18
@ma91n ma91n marked this pull request as ready for review January 29, 2025 14:18
@ota-meshi ota-meshi merged commit da43334 into master Jan 29, 2025
3 checks passed
@ota-meshi ota-meshi deleted the feature/gitbranch_move_to_arch-guidelines branch January 29, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants