Korean layouts

[tenextractor]

From Gboard, needs combiner to work

• 두벌식 (Dubeolsik)
  

• 난모음 (Danmoeum)
  

[plumpdolphin]

The layouts look great to me; very clean!
I do see a couple of things that look out of place, though they are very minor:

1. The Korean spelling of the Danmoeum keyboard should be 단모음 instead of 난모음 (pronounced Nanmoeum).
2. In the Dubeolsik layout when shifting manually, it seems you have accidentally swapped the first ㅈ key with a second ㅊ key. The shifted state is correctly set to ㅉ, however.

That quick fix aside, nicely done!

[tenextractor]

@plumpdolphin Thanks for the corrections, they have been fixed, moreover it would be a great help if you could build and test futo-org/android-keyboard#899 which has the combining logic.

[plumpdolphin]

@plumpdolphin Thanks for the corrections, they have been fixed, moreover it would be a great help if you could build and test futo-org/android-keyboard#899 which has the combining logic.

Just tested it and it seems to work great! I made a couple of comments there as well for you to see, but putting this down here as well to say that the combination of the two checks off all the boxes in my testing!

[plumpdolphin]

One small issue I've noticed after a day or so of use: the Danmoeum/단모음 keyboard's number line is missing the 1 and 0 when the Show Number Row setting is disabled. This is easily fixed by just using the standalone number row, which is the standard way that Danmoeum is presented and used anyways.

So not sure if it's possible, but might be necessary to open another issue on enabling that setting by default on certain layouts. (If it's not already)

Otherwise, if the numbers are to be embedded in the keys as secondaries, it's more common from what I'm seeing for the 1 to start on ㅂ and continue through to 8, with ㅏ = 9 and 0 = ㅣ. (See example)

Without looking further, I'm not sure if it's possible to override the placement of the numbers from the YAML configuration, and whether those numbers could be removed if the user has the standalone number row enabled.

[plumpdolphin]

You may also add the language to the mapping.yaml in another commit on this PR, I'm guessing that it was just missed in adding the files to version control. Then hopefully we can get this show on the road; I can't wait for others to be able to daily drive this layout! 😄

[tenextractor]

Thanks for pointing it out, updated mapping.yaml

[tenextractor]

@plumpdolphin the easiest way to fix numbers on Danmoeum is to put 1 under ㅁ and 0 under ㅣ

[tenextractor]

Layouts use the combiner field now

[tenextractor]

For some reason, shift is applied automatically even after specifying attributes: {shiftable: false} in the layout. This means that the user has to press shift twice, once to go from shifted to normal, and another time to go from normal to shiftedManually to get shifted characters.

The same thing happens with the Georgian layout.

[jeongm-in]

This is amazing, missing Korean layout was the only thing that was stopping me from completely switching from SwiftKey to Futo. I'll test this out as well and leave any comment if I find any issues.

Happy to report that I did not run into any issues after extensive use. Again, amazing work!