Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pair type import to work in cljc #225

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Update pair type import to work in cljc #225

merged 1 commit into from
Nov 28, 2018

Conversation

Saityi
Copy link
Contributor

@Saityi Saityi commented Nov 28, 2018 •
edited
Loading

Addresses #224 @Bost

The issue is that type imports are different in Clojure and Clojurescript.

@Saityi Saityi changed the title Update pair type import to work in cljs and clj-jvm Update pair type import to work in cljc Nov 28, 2018
sovelten
sovelten approved these changes Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@sovelten sovelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@sovelten sovelten merged commit 657f4a7 into funcool:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovelten sovelten sovelten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saityi @sovelten