Toast 추가 #83
Merged
Toast 추가 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Nov 5, 2023
Leejin-Yang
reviewed
Nov 5, 2023
Comment on lines
1
to
14
| import { useContext } from 'react'; | ||
|
|
||
| import { ToastActionContext } from '../../contexts/ToastContext'; | ||
|
|
||
| const useToastActionContext = () => { | ||
| const toastAction = useContext(ToastActionContext); | ||
| if (toastAction === null || toastAction === undefined) { | ||
| throw new Error('useToastActionContext는 Toast Provider 안에서 사용해야 합니다.'); | ||
| } | ||
|
|
||
| return toastAction; | ||
| }; | ||
|
|
||
| export default useToastActionContext; |
There was a problem hiding this comment.
ValueContext인데 ActionContext로 되어 있네요!
|
@xodms0309 아마 제 예상대로라면 hook을 export 해서 원래 사용하던대로 쓸 거 같아요! |
타미말과 동일한 의견이었습니다! useToastActionContext 😊 |
|
useToastActionContext 이거 자체에 export 붙여야하나요? |
|
@hae-on index 가 entry point라서 저기에서 export해야 하지 않나여?!?? |
|
@Leejin-Yang @xodms0309 |
xodms0309
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
toast를 옮겼습니다.
📢 논의하고 싶은 내용
여기의 props는 사실상 사용자가 몰라도 되는 값이라고 생각합니다.
실질적으로 toast.success 이렇게 사용하니까요!
이런 경우는 JSDocs와 리드미 작성을 어떻게 할까요?
그냥 이전 경우와 똑같이 설명을 작성할까요 아니면 props 부분을 적지 말까요??
🎸 기타
x