-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add verbose retry when installing dependencies #126
base: main
Are you sure you want to change the base?
Conversation
We should probably pull this into the Python template too. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 26 26
Lines 1789 1789
Branches 215 215
=======================================
Hits 1732 1732
Misses 31 31
Partials 26 26 ☔ View full report in Codecov by Sentry. |
WalkthroughThe workflow configuration in the 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)
48-48
: LGTM. Consider these improvements.Consider this enhanced retry logic:
-run: poetry install -v --no-cache || poetry install -vv --no-cache +run: | + poetry install || \ + (echo "::warning::First install attempt failed. Retrying with verbose logging..." && \ + sleep 2 && \ + poetry install -vv)Changes:
- Removes
--no-cache
to improve speed- Adds warning message
- Adds delay between attempts
Summary
If
poetry install
fails in the test run, try again with increased verbosity.The retry may resolve transient errors, and if it doesn't, we get a more detailed error log.